lf-edge / eden

Eden is where EVE and Adam get tried and tested:
https://projecteve.dev
Apache License 2.0
49 stars 47 forks source link

Fix http datastore fqdn address #1005

Closed shjala closed 1 month ago

shjala commented 1 month ago

In case the http datastore address has a port number, the datastore address should contain both the hostname and the port.

shjala commented 1 month ago

LGTM, thanks @shjala ! Could you please add comment from your commit to the change, so it won't be gone if we rewrite commit? I think it's a useful comment for people :)

I'm not sure what you mean, this is the commit message, should I add more to it?

Fix http datastore fqdn address
In case the http datastore address has a port number, the datastore address
should contain both the hostname and the port.

Signed-off-by: Shahriyar Jalayeri <shahriyar@zededa.com>
shjala commented 1 month ago

@uncleDecart got it, added.