search

lf-edge / eden

Eden is where EVE and Adam get tried and tested:
https://projecteve.dev
Apache License 2.0
50 stars 48 forks source link

Remove viper config serialization #926

Open uncleDecart opened 11 months ago

uncleDecart commented 11 months ago

This continues work on removing viper from openevec package so that we can create default configuration structure and use it to call openevec functions in golang.

In this PR use EdenSetupArgs default generated config in config add function. That means that we remove configuration generated from templates (so there are no comments or spacing in file, just pure yml, we can, of course add template comments to struct fields in go file) Also we force cloudPrepare() function to use EdenSetupArgs, because before it fetched variables from viper, which creates unnecessary coupling and forces us to create file and use viper in openevec.

So far I played with default parameters, will try to change configurations.

giggsoff commented 11 months ago

It looks like something broken: https://github.com/lf-edge/eden/actions/runs/6902762877/job/18780102814#step:11:21. As I can see there is double dist in path there.

uncleDecart commented 11 months ago

Let's try this one :)

uncleDecart commented 11 months ago

There are some more changes needed in test cmd

uncleDecart commented 11 months ago

Okaay, test cmd fixed, let's see how it runs :crossed_fingers:

uncleDecart commented 11 months ago

That's weird, locally smoke tests are running, in CI/CD tests are green, but I think they didn't run (10 mins is way to less for tests to finish)

uncleDecart commented 11 months ago

log_tests is failing, something is wrong with certificate path, looking into it...

uncleDecart commented 11 months ago

tests are passing, but we are failing on getting logs, checking what's up