search

lf-edge / eden

Eden is where EVE and Adam get tried and tested:
https://projecteve.dev
Apache License 2.0
49 stars 47 forks source link

[WIP]: Fix arguments for Edge Application #959

Closed rene closed 6 months ago

rene commented 7 months ago

[WORK IN PROGRESS, please don't merge]

EVE changed a bit the way of parsing custom configuration options for Edge Applications in order to avoid break containers due to variables that were doubled quoted. For instance:

myvar = "value"

Was breaking containers because it was interpreted like this:

myvar = ""value""

Now EVE trims spaces and double quotes from the value before write the declaration in environment file.

This commit fixes some declarations in swtich_net_vlans.txt that were leading to variables defined like this (also breaking containers):

"myvar = "value"

rene commented 7 months ago

Should we also add some validation into EVE so that user gets clear indication what is wrong (instead of crashing the init process and triggering kernel panic)?

Sure @milan-zededa , it must be fixed on EVE as well... I'll open a PR on EVE....

rene commented 6 months ago

With the improvements brought by this PR https://github.com/lf-edge/eve/pull/3760, these changes will not be required anymore. I'm closing this PR.