search

lf-edge / eden

Eden is where EVE and Adam get tried and tested:
https://projecteve.dev
Apache License 2.0
49 stars 47 forks source link

vendor: add vendor directory to fix build #973

Closed eriknordmark closed 3 months ago

eriknordmark commented 3 months ago

The build is failing due to go mod complaints. Adding a vendor dir (using go mod vendor) fixes the build.

giggsoff commented 3 months ago

Curious, which error can you see during build? Vendoring have pros and cons, but I am not sure that it was intended to solve such errors. We have several places potentially to make vendoring if it is required ( sdn/vm, tests/eclient/image/pkg, eserver).

eriknordmark commented 3 months ago

Curious, which error can you see during build? Vendoring have pros and cons, but I am not sure that it was intended to solve such errors. We have several places potentially to make vendoring if it is required ( sdn/vm, tests/eclient/image/pkg, eserver).

@giggsoff There might be more vendor places that have issues. Yesterday I asked dependabot to rebase a number of its PRs against eden, and some failed e.g., unit tests due to vendor/modules.txt not matching, and others failed due to missing vendored files such as https://github.com/lf-edge/eden/actions/runs/9264673168/job/25485194492?pr=971

eriknordmark commented 3 months ago

No need for this.