search

lf-edge / eden

Eden is where EVE and Adam get tried and tested:
https://projecteve.dev
Apache License 2.0
49 stars 47 forks source link

GitHub Actions: Login to DockerHub #988

Closed uncleDecart closed 2 months ago

uncleDecart commented 2 months ago

Testing hits DockerHub pull rate limit. Previosly considered migration option ghcr, has pull rate limits now as well. Step to solving this problem is to add logging in, that way it'll be 200 pulls per day instead of 100 per shared IP address with BuildJet runners

uncleDecart commented 2 months ago

I'm gonna branch out rn and create EVE PR pointing to Eden's branch

uncleDecart commented 2 months ago

PR to merge into my own branch here

giggsoff commented 2 months ago

Is it secure to pass secrets via inputs?

uncleDecart commented 2 months ago

Is it secure to pass secrets via inputs?

Yep @giggsoff , we do that in EVE repository for run-make action here

giggsoff commented 2 months ago

Is it secure to pass secrets via inputs?

Yep @giggsoff , we do that in EVE repository for run-make action here

I can see special option to pass secrets to reusable workflows, is it better to use it instead?

giggsoff commented 2 months ago

Looks like it still has problems: link. Or am I missing something?

uncleDecart commented 2 months ago

Okay, looks like it's fixed

uncleDecart commented 2 months ago

Okay, I opened PR on EVE side pointing to Eden test branch and it seemed to work. I'm removing do not merge sign and wait for some time till I merge this PR into master. With new Eden release we will have hopefully less request timeouts :)