search

lf-edge / eden

Eden is where EVE and Adam get tried and tested:
https://projecteve.dev
Apache License 2.0
49 stars 47 forks source link

Increase timeout for deployment of two nginx apps #993

Closed milan-zededa closed 2 months ago

milan-zededa commented 2 months ago

10 minutes is sometimes not enough with ZFS and slower runner.

milan-zededa commented 2 months ago

LGTM, but I'm wondering if this is hacking our way through async programming? Or another words, can we write code so that it'll be all on async handlers and there will be no need for timeouts

This is not sleep. We deploy app then wait for it to be RUNNING. As soon as we receive info that it is running, test continues. But there has to be some timeout to eventually give up if eve is failing to deploy.

uncleDecart commented 2 months ago

This is not sleep. We deploy app then wait for it to be RUNNING. As soon as we receive info that it is running, test continues. But there has to be some timeout to eventually give up if eve is failing to deploy.

Do you think it makes sense to have timeouts for each operation or should it be one timeout for whole test suite rather than per test?

milan-zededa commented 2 months ago

This is not sleep. We deploy app then wait for it to be RUNNING. As soon as we receive info that it is running, test continues. But there has to be some timeout to eventually give up if eve is failing to deploy.

Do you think it makes sense to have timeouts for each operation or should it be one timeout for whole test suite rather than per test?

For the whole test suite we would have to use pretty large timeout. I don't think it would make sense to wait for an hour for e.g. an app to start running.

uncleDecart commented 2 months ago

Makes sense