lf-edge / eve-api

Repository for eve-api code
Apache License 2.0
0 stars 13 forks source link

Improve workflows #25

Closed eriknordmark closed 1 year ago

eriknordmark commented 1 year ago

Seems like the diff check in ci.yaml is using a constant and not a variable. Fixes issue #20 And we want to exclude the images from the comparison since the buider produces different output each time it is run with identical source files.

Second commit was just checking yamllint and discovering that the indentation etc is off for yetus.yaml.

deitch commented 1 year ago

And we want to exclude the images from the comparison

Yes, it is a frustration of mine. I have reached out to the maintainers, but have not heard back. I dug into how the images are generated, and it is fixable, but we are blocked until they respond. I will ping them again.

I kept the image check under the assumption that we would fix it quickly, and thus better to be sure it was changed. Clearly, it is not happening quickly, so your approach is better.