lf-edge / eve-api

Repository for eve-api code
Apache License 2.0
0 stars 13 forks source link

README: fix the slightly misleading doc #30

Closed rouming closed 1 year ago

rouming commented 1 year ago

make proto command runs protocol generation based on the tools installed on your local machine, which is not what really expected, because tools can be outdated.

make calls a make proto from a container, so all tools are of the correct versions.

This patch changes make proto to just make in all docs.

CC: @deitch

rouming commented 1 year ago

Ping @eriknordmark @deitch

rouming commented 1 year ago

This doesn't fit what I see in the Makefile:

The 'proto-container' is the first goal, which is the default for the make, so when you call 'make' you invoke the 'make proto-container'.

deitch commented 1 year ago

Oh. Ok. It's a bit confusing. You're right about the flow.

deitch commented 1 year ago

No idea why it won't let me review again. I'll just merge.