IP routing config for local network instances

lf-edge / eve-api

Repository for eve-api code

Apache License 2.0

0 stars 13 forks source link

IP routing config for local network instances #38

Closed milan-zededa closed 11 months ago

milan-zededa commented 11 months ago

These new fields will allow to:

use DHCP to automatically propagate routes for uplink subnets into applications connected to them indirectly through local network instances
configure static IP routes for local network instances and propagate them using DHCP to connected applications

naiming-zededa commented 11 months ago

we can also introduce a new api-capability for this feature, otherwise user configured static-routes in the cloud side and wondering why it does not show up on the device.

milan-zededa commented 11 months ago

Marking this as draft until some design discussions are closed. Then will also make changes requested in review.

milan-zededa commented 11 months ago

we can also introduce a new api-capability for this feature, otherwise user configured static-routes in the cloud side and wondering why it does not show up on the device.

Done, added new API capability.

milan-zededa commented 11 months ago

@eriknordmark, @naiming-zededa PR is ready for re-review.

milan-zededa commented 11 months ago

LGTM, but as we add this should we also add something about propagate/inject default route or not in the API? Today we do that by default and can disable it by setting the gateway (for the network if I don't misremember - or is it on the network instance?)

If nothing else, how about documenting that near the comment about static_routes?

Done, added comments explaining default route propagation.