search

lf-edge / eve-api

Repository for eve-api code
Apache License 2.0
0 stars 13 forks source link

Devmodel add usb #45

Closed christoph-zededa closed 8 months ago

christoph-zededa commented 8 months ago

devmodelcommon.proto: Add types for USB devices

Unfortunately I forgot to add these types before and one commercial controller started using the IDs 13 and 14, therefore we (@rene@github.com and I) decided to squeeze in these types and increase the IDs for CAN as they're not used yet.

christoph-zededa commented 8 months ago

Yetus fails:


yetus: proto/evecommon/devmodelcommon.proto#L27
bufcompat:Enum value "13" on enum "PhyIoType" changed name from "PhyIoCAN" to "PhyIoUSBController".
yetus: proto/evecommon/devmodelcommon.proto#L27
buflint:Enum value name "PhyIoUSBController" should be prefixed with "PHY_IO_TYPE_".
yetus: proto/evecommon/devmodelcommon.proto#L27
buflint:Enum value name "PhyIoUSBController" should be UPPER_SNAKE_CASE, such as "PHY_IO_USB_CONTROLLER".
yetus: proto/evecommon/devmodelcommon.proto#L28
bufcompat:Enum value "14" on enum "PhyIoType" changed name from "PhyIoVCAN" to "PhyIoUSBDevice".
yetus: proto/evecommon/devmodelcommon.proto#L28
buflint:Enum value name "PhyIoUSBDevice" should be prefixed with "PHY_IO_TYPE_".
yetus: proto/evecommon/devmodelcommon.proto#L28
buflint:Enum value name "PhyIoUSBDevice" should be UPPER_SNAKE_CASE, such as "PHY_IO_USB_DEVICE".
yetus: proto/evecommon/devmodelcommon.proto#L29
bufcompat:Enum value "15" on enum "PhyIoType" changed name from "PhyIoLCAN" to "PhyIoCAN".

It complains about changing the IDs, which is expected and it complains about UPPER_SNAKE_CASE, but we want to keep the style.

rene commented 8 months ago

Yetus fails:


yetus: proto/evecommon/devmodelcommon.proto#L27
bufcompat:Enum value "13" on enum "PhyIoType" changed name from "PhyIoCAN" to "PhyIoUSBController".
yetus: proto/evecommon/devmodelcommon.proto#L27
buflint:Enum value name "PhyIoUSBController" should be prefixed with "PHY_IO_TYPE_".
yetus: proto/evecommon/devmodelcommon.proto#L27
buflint:Enum value name "PhyIoUSBController" should be UPPER_SNAKE_CASE, such as "PHY_IO_USB_CONTROLLER".
yetus: proto/evecommon/devmodelcommon.proto#L28
bufcompat:Enum value "14" on enum "PhyIoType" changed name from "PhyIoVCAN" to "PhyIoUSBDevice".
yetus: proto/evecommon/devmodelcommon.proto#L28
buflint:Enum value name "PhyIoUSBDevice" should be prefixed with "PHY_IO_TYPE_".
yetus: proto/evecommon/devmodelcommon.proto#L28
buflint:Enum value name "PhyIoUSBDevice" should be UPPER_SNAKE_CASE, such as "PHY_IO_USB_DEVICE".
yetus: proto/evecommon/devmodelcommon.proto#L29
bufcompat:Enum value "15" on enum "PhyIoType" changed name from "PhyIoLCAN" to "PhyIoCAN".

It complains about changing the IDs, which is expected and it complains about UPPER_SNAKE_CASE, but we want to keep the style.

Yeah, both can be ignored.