lf-edge / eve-api

Repository for eve-api code
Apache License 2.0
0 stars 13 forks source link

Add allow to discover #47

Closed uncleDecart closed 8 months ago

uncleDecart commented 8 months ago

This flag will allow to expose app instance IP address via metadata server. Could be useful when you have certain topology and don't want to have static IP routes, i.e. sidecar applications.

uncleDecart commented 8 months ago

I thought the idea was to only have setting on the app instance to allow discover. Am I confused?

We can move it to app instance level, but this way we can give access granularly, i.e. expose specific port of app instance

eriknordmark commented 8 months ago

I thought the idea was to only have setting on the app instance to allow discover. Am I confused?

We can move it to app instance level, but this way we can give access granularly, i.e. expose specific port of app instance

The initial proposal was to have it both on the network instance and the app instance, which seems overkill. Only on the network instance means that anybody and everybody can discover, which seems to relaxed. But only on the app instance should be sufficient for the initial use for the sidecar container, and less to configure.

uncleDecart commented 8 months ago

I thought the idea was to only have setting on the app instance to allow discover. Am I confused?

We can move it to app instance level, but this way we can give access granularly, i.e. expose specific port of app instance

The initial proposal was to have it both on the network instance and the app instance, which seems overkill. Only on the network instance means that anybody and everybody can discover, which seems to relaxed. But only on the app instance should be sufficient for the initial use for the sidecar container, and less to configure.

Makes sense, updated it with app instance. We should publish doc on lfedge wiki

uncleDecart commented 8 months ago

Please fix comment. Then ready to go.

@eriknordmark done