lf-edge / eve

EVE is Edge Virtualization Engine
https://www.lfedge.org/projects/eve/
Apache License 2.0
468 stars 158 forks source link

Add disk group for mdev zvol enumeration #3996

Closed andrewd-zededa closed 1 week ago

andrewd-zededa commented 1 week ago

Resolve regression from commit 3f78153.

Touching /dev/mdev.log would show mdev errors like the below:

mdev[2051]: unknown user/group 'root:disk' on line 7

andrewd-zededa commented 1 week ago
ERROR: failed to solve: golang:1.20.1-alpine: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/golang/manifests/sha256:87d0a3309b34e2ca732efd69fb899d3c420d3382370fd6e7e6d2cb5c930f27f9: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
make: *** [Makefile:944: eve-build-ubuntu] Error 1
Error: Process completed with exit code 2.

too many pulls on latest build...

andrewd-zededa commented 1 week ago

Added a yetus header complaint fix in pkg/pillar/build-kubevirt.yml so that I could kick the build again.

andrewd-zededa commented 1 week ago

Pushed a rebase

andrewd-zededa commented 1 week ago

newline on the yml file for yetus

eriknordmark commented 1 week ago

newline on the yml file for yetus

What about the build failure in https://github.com/lf-edge/eve/actions/runs/9668949206/job/26674312202?pr=3996

andrewd-zededa commented 1 week ago

yeah I think the tag changed again, must have been during my rebase. One more try

andrewd-zededa commented 1 week ago

I'm waiting for more builds to complete locally, the go tests failure is odd

eriknordmark commented 1 week ago

I'm waiting for more builds to complete locally, the go tests failure is odd

Did you try a make test in your workspace?

andrewd-zededa commented 1 week ago

reverted the pkg/pillar/Dockerfile back to origin/master. Will push in separate pr.

andrewd-zededa commented 1 week ago

I'm waiting for more builds to complete locally, the go tests failure is odd

Did you try a make test in your workspace?

yeah, it failed for not having a local containerd to run against but ran many other tests. It didn't fail due to the dom0-ztools tag.

andrewd-zededa commented 1 week ago

lf-edge/eden get-run-id failure (pull_request_review)

Error: No successful runs found
    at eval (eval at callAsyncFunction (/home/runner/work/_actions/actions/github-script/v7/dist/index.js:35424:16), <anonymous>:11:11)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async main (/home/runner/work/_actions/actions/github-script/v7/dist/index.js:35522:20)
Error: Unhandled error: Error: No successful runs found

I'm not sure what to make of this failure

andrewd-zededa commented 1 week ago

lf-edge/eden get-run-id failure (pull_request_review)

Error: No successful runs found
    at eval (eval at callAsyncFunction (/home/runner/work/_actions/actions/github-script/v7/dist/index.js:35424:16), <anonymous>:11:11)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async main (/home/runner/work/_actions/actions/github-script/v7/dist/index.js:35522:20)
Error: Unhandled error: Error: No successful runs found

I'm not sure what to make of this failure

never mind, it switched to skipped after resolving the pkg/pillar/Dockerfile changes needed. If this is merged I'll submit a PR to bump dom0-ztools tag in pillar.