Include bpftrace by src part3

lf-edge / eve

EVE is Edge Virtualization Engine

https://www.lfedge.org/projects/eve/

Apache License 2.0

468 stars 158 forks source link

Include bpftrace by src part3 #4018

Open christoph-zededa opened 1 week ago

milan-zededa commented 3 days ago

@christoph-zededa has to push again to trigger build workflows. There was some (hopefully intermittent) problem 4 days ago with build workflows not getting triggered.

christoph-zededa commented 3 days ago

Build problem was:

make: *** No rule to make target 'pkg/bpftrace@sha256', needed by 'pkg/debug'.  Stop.

Because I don't know how to get a "classical" image hash for eve-bpftrace:latest (I used docker image inspect).

So I added a fix for this regex.

eriknordmark commented 3 days ago

You can find the sha in https://hub.docker.com/r/lfedge/eve-bpftrace/tags, or using a docker pull. But I have no idea how this is done for riscv64. Do we omit other packages like this from the riscv build @rene ?

christoph-zededa commented 3 days ago

You can find the sha in https://hub.docker.com/r/lfedge/eve-bpftrace/tags, or using a docker pull.

> docker pull lfedge/eve-bpftrace:latest
latest: Pulling from lfedge/eve-bpftrace
Digest: sha256:1cc6c47ffc231db98283e763e02b111bc1503cddbb64f4718e021b9d1fd7ee3f

even then I only see the sha256 hash; I've found https://hub.docker.com/layers/lfedge/eve-bpftrace/f8effaa3169f9e7f1ee71b63c904da62ce0e0212-arm64/images/sha256-990a275ed710c81e6ca052cd2b7e57cbb87b23ade2136f4e59a7636b12e18b8d?context=explore - so using this now.

But I have no idea how this is done for riscv64. Do we omit other packages like this from the riscv build @rene ?

I think I have to add it to https://github.com/lf-edge/eve/blob/master/Makefile#L380 or disable debug container for riscv64. Let's see if this helps or if I need a separate PR.

rene commented 3 days ago

You can find the sha in https://hub.docker.com/r/lfedge/eve-bpftrace/tags, or using a docker pull.
> docker pull lfedge/eve-bpftrace:latest
latest: Pulling from lfedge/eve-bpftrace
Digest: sha256:1cc6c47ffc231db98283e763e02b111bc1503cddbb64f4718e021b9d1fd7ee3f
even then I only see the sha256 hash; I've found https://hub.docker.com/layers/lfedge/eve-bpftrace/f8effaa3169f9e7f1ee71b63c904da62ce0e0212-arm64/images/sha256-990a275ed710c81e6ca052cd2b7e57cbb87b23ade2136f4e59a7636b12e18b8d?context=explore - so using this now.

But I have no idea how this is done for riscv64. Do we omit other packages like this from the riscv build @rene ?

I think I have to add it to https://github.com/lf-edge/eve/blob/master/Makefile#L380 or disable debug container for riscv64. Let's see if this helps or if I need a separate PR.

Correct, PKGS_riscv64 is used for riscv64 packages since many other packages are not yet supported...

christoph-zededa commented 3 days ago

converted to draft, because https://github.com/lf-edge/eve/pull/4044 fails too seems packages are missing for riscv64 to build bpftrace on alpine