milan-zededa
commented
4 days ago LGTM
Did some test fail due to this uevent issue?
Yes, one of the smoke tests caught panic:
2024-07-01 08:55:03.514|null|pillar|| panic: bufio: reader returned negative count from Read
2024-07-01 08:55:03.514|null|pillar|| null
2024-07-01 08:55:03.515|null|pillar|| goroutine 489 [running]:
2024-07-01 08:55:03.519|null|pillar|| bufio.(*Reader).fill(0xc000ef9f18)
2024-07-01 08:55:03.521|null|pillar|| /usr/lib/go/src/bufio/bufio.go:108 +0x19b
2024-07-01 08:55:03.523|null|pillar|| bufio.(*Reader).ReadSlice(0xc000ef9f18, 0x20?)
2024-07-01 08:55:03.525|null|pillar|| /usr/lib/go/src/bufio/bufio.go:372 +0x2f
2024-07-01 08:55:03.528|null|pillar|| bufio.(*Reader).collectFragments(0x5?, 0xe0?)
2024-07-01 08:55:03.530|null|pillar|| /usr/lib/go/src/bufio/bufio.go:447 +0x74
2024-07-01 08:55:03.532|null|pillar|| bufio.(*Reader).ReadString(0x1000?, 0x0?)
2024-07-01 08:55:03.537|null|pillar|| /usr/lib/go/src/bufio/bufio.go:494 +0x2b
2024-07-01 08:55:03.537|null|pillar|| github.com/eshard/uevent.(*Decoder).next(...)
2024-07-01 08:55:03.538|null|pillar|| /pillar/vendor/github.com/eshard/uevent/decoder.go:81
2024-07-01 08:55:03.538|null|pillar|| github.com/eshard/uevent.(*Decoder).Decode(0xc000ef9d90)
2024-07-01 08:55:03.539|null|pillar|| /pillar/vendor/github.com/eshard/uevent/decoder.go:42 +0x67
2024-07-01 08:55:03.539|null|pillar|| github.com/lf-edge/eve/pkg/pillar/cmd/usbmanager.(*usbmanagerController).listenUSBPorts.func2()
2024-07-01 08:55:03.540|null|pillar|| /pillar/cmd/usbmanager/usbevent.go:46 +0x387
2024-07-01 08:55:03.541|null|pillar|| created by github.com/lf-edge/eve/pkg/pillar/cmd/usbmanager.(*usbmanagerController).listenUSBPorts
2024-07-01 08:55:03.542|null|pillar|| /pillar/cmd/usbmanager/usbevent.go:34 +0x1cf
include this fix: https://github.com/eshard/uevent/commit/d8d2be286cec29be49051fbecc642a27c8efd672