search

lf-lang / lf-python-support

Python package for supporting code generated by the Lingua Franca compiler
Other
5 stars 0 forks source link

Attempt to fix Windows problem with Python build #23

Closed edwardalee closed 1 year ago

edwardalee commented 1 year ago

Windows and Posix disagree (of course) on how to define maximum path length. A build failure unrelated to anything else I am doing started appearing because the following fails to define PATH_MAX:

#ifdef _MSC_VER
#ifndef PATH_MAX
#define PATH_MAX MAX_PATH
#endif
#endif

This PR replaces this with:

#if defined(WIN32) || defined(_WIN32) || defined(__WIN32__) || defined(__NT__)
#ifndef PATH_MAX
#define PATH_MAX MAX_PATH
#endif
#endif

Hopefully this will be more robust.

edwardalee commented 1 year ago

This fix did not work. It turns out that the test failures are fixed by using the bodiless-reactions branch. I'm going to merge that branch with main.

lhstrh commented 1 year ago

I'm not sure I understand. The bodiless-reactions branch has been merged earlier this week...