Feedback in diagrams

[edwardalee]

The following minimal program illustrates two alignment problems with decorators put on connections:

On the feedback path, the decorator is put above the connection rather than on it, and on the feedforward path, the alignment is slightly off. The test case is here:

target Python
reactor Foo {
  input x
  output y
}
main reactor {
  f = new Foo()
  f2 = new Foo()
  f.y ~> f.x after 10ms
  f.y ~> f2.x
}

[soerendomroes]

The slightly-off issue has been fixed in ELK 0.9.0. The self-loop issue appears to persist and is an issue in ELK.

[lhstrh]

@soerendomroes, is there anything actionable? Or is there maybe a GitHub issue that we can link to in ELK?

[lhstrh]

@soerendomroes and @a-sr, bumping this issue.

[soerendomroes]

See https://github.com/eclipse/elk/issues/1023

[lhstrh]

The issue says "This should have been fixed in 0.9.0" so does that mean the issue is fixed and we can close this? Or does it mean that a dependency needs to be bumped?

[lhstrh]

You also mentioned that "The self-loop issue appears to persist and is an issue in ELK." Is there an actual issue were this is tracked in ELK?

[soerendomroes]

@lhstrh The issue is tracked in https://github.com/eclipse/elk/issues/1023 in ELK.