search

lf-lang / lingua-franca

Intuitive concurrent programming in any language
https://www.lf-lang.org
Other
234 stars 62 forks source link

Add RPi pico support for v0.7 #2283

Closed erlingrj closed 3 months ago

erlingrj commented 4 months ago

The RPi pico support needs updates to support v0.7. In this PR I make a few minor changes needed. I have not setup the pico toolchain locally so haven't tested it. See: https://github.com/lf-lang/lingua-franca/issues/2282 Maybe @sberkun can follow up on it?

Would be great with a simple CI test that at least builds a hello world to avoid this in the future. Do you have any estimate of how hard that would be Samuel?

sberkun commented 4 months ago

Sorry for the delay! Following some recent changes (splitting the runtime into many CMake modules), the libraries need to be added to lf-low-level-platform-api as well as reactor-c. https://github.com/lf-lang/reactor-c/pull/344 addresses lf-low-level-platform-api and this PR (or #2178) addresses reactor-c.

Setting up a compilation test should be doable, the main steps are:

I'm not familiar with how the automated tests are set up, but I imagine this could be accomplished by copying the Ubuntu tests and adding a few lines.

edwardalee commented 4 months ago

Looks like this change is also included in #2178, so I think this can be safely be closed.

lhstrh commented 4 months ago

Looks like this change is also included in #2178, so I think this can be safely be closed.

@sberkun, could you confirm this?

lhstrh commented 3 months ago

Given the lack of response I'm assuming it's safe to close this.