search

lf-lang / lingua-franca

Intuitive concurrent programming in any language
https://www.lf-lang.org
Other
220 stars 57 forks source link

naming banked reactors #2320

Open OmerMajNition opened 2 weeks ago

OmerMajNition commented 2 weeks ago

https://github.com/lf-lang/lingua-franca/issues/2319 has the description of the problem addressed with this PR

cmnrd commented 1 week ago

I am not entirely sure what this tries to achieve. Is this about getting the fully qualified names of reactors? I think we already provide functionality for that, also in the C target.

cmnrd commented 1 week ago

@petervdonovan Could you comment on this? Are there FQNs available in C, and how are they exposed?

petervdonovan commented 1 week ago

Are there FQNs available in C, and how are they exposed?

If they are available in the C target, I am not aware of them, and after looking briefly I do not see them in the source code (in particular, there is no name field in the self_base_t struct defined here.

It looks like this PR adds FQNs without requiring any extension of self_base_t when the name field is not used, so I think we might as well merge it. CI is failing, but I think that should be easily fixed.

cmnrd commented 1 week ago

Ok. I still don't understand what the PR does, though. @OmerMajNition could you add some explanation? Is the idea to introduce a magic parameter name that gets automatically assigned the FQN?

OmerMajNition commented 4 days ago

@cmnrd , I've added further description in GH-Issue: https://github.com/lf-lang/lingua-franca/issues/2319. Please let me know if we need further clarification.