Closed cmnrd closed 1 week ago
The DockerComposeGenerator.java
file has undergone two sequential changes to the createLauncher
method. Initially, the docker compose up
command integrated the --abort-on-container-exit
flag. Subsequently, this flag was replaced by the --abort-on-container-failure
flag. These changes aim to modify how the Docker Compose setup reacts when containers exit or fail.
Files | Change Summary |
---|---|
core/src/main/java/org/lflang/generator/docker/DockerComposeGenerator.java |
Updated the docker compose up command to include the --abort-on-container-exit flag, then further updated to use the --abort-on-container-failure flag. |
sequenceDiagram
participant User
participant DockerComposeGenerator
participant Docker
User->>DockerComposeGenerator: Invoke createLauncher()
DockerComposeGenerator->>Docker: docker compose up
Docker-->>DockerComposeGenerator: Containers start
Docker->>DockerComposeGenerator: Container failure detection
DockerComposeGenerator-->>User: Process aborts on container failure
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Addresses https://github.com/lf-lang/lingua-franca/pull/2328#pullrequestreview-2131194763
Summary by CodeRabbit
--abort-on-container-failure
flag to ensure that all containers are stopped if one fails.--abort-on-container-exit
flag to thedocker compose up
command to ensure the service stops if any container exits.