search

lf-lang / reactor-c

A reactor runtime written in C
Other
11 stars 24 forks source link

Update RTI dockerfile to match file layout change #399

Closed petervdonovan closed 6 months ago

petervdonovan commented 6 months ago

This could harm reproducibility and could increase the size of the RTI image. However, reproducibility is actually not much worse than the status quo which was still copying whole directories. Also, the amount of extra stuff copied is small. In the long run this will keep us from running into further problems as we continue to refactor this repo without testing the dockerized RTI build in CI (I am assuming that it is not worthwhile to add a test for it in CI)

I have manually verified that this does build locally.

erlingrj commented 6 months ago

Hm, @lhstrh told me that the target parameter:

  docker: {
    rti-image: "rti:local"
  }

Would trigger lfc to build a docker image, presumably with the Dockerfile, and this is apparently used in CI, I wonder why those tests didn't fail after your refactoring Peter

petervdonovan commented 6 months ago

I wonder why those tests didn't fail after your refactoring Peter

OK, filed a PR (https://github.com/lf-lang/lingua-franca/pull/2249) to fix the error handling.