search

lf-lang / reactor-c

A reactor runtime written in C
Other
10 stars 23 forks source link

Fix support for NRF52 #442

Closed edwardalee closed 4 days ago

edwardalee commented 1 month ago

With the refactoring of platform support, code generation for NRF52 stopped working. This gets it working again, albeit with quite a few limitations. To program an nRF52 board, we suggest starting with the lf-nRF52 repository. The limitations are documented there.

Summary by CodeRabbit

lhstrh commented 3 weeks ago

Any particular reason this is still marked as draft?

edwardalee commented 3 weeks ago

It needs to support soft devices before it's ready for prime time. I'm not sure how to specify in the target parameters whether and which soft device you want. And the makefile generation needs to be tuned. We also need to verify that these changes don't break the Zepher support for nRF52.

coderabbitai[bot] commented 1 week ago

Walkthrough

The changes focus on improving code efficiency, consistency, and documentation across various files. In lib/schedule.c, variables are better reused to enhance the efficiency of the lf_schedule_trigger function. Various CMakeLists.txt files are updated to correct and consistently use the platform name "nRF52". Additionally, lf_nrf52_support.{h,c} files are refactored for better interrupt handling and clearer documentation. Lastly, a macro is added to platform/impl/CMakeLists.txt for streamlined preprocessor definitions.

Changes

Files Change Summary
lib/schedule.c Introduced external variable declarations for event_t to reuse across switch cases in lf_schedule_trigger.
.../low_level_platform/api/CMakeLists.txt Changed platform name comparison from "Nrf52" to "nRF52" for consistency.
.../low_level_platform/api/platform/lf_nrf52_support.h Updated documentation comments to correct platform name and author tags formatting.
.../low_level_platform/impl/CMakeLists.txt Corrected platform name in conditional statements and error messages, and updated status message.
.../low_level_platform/impl/src/lf_nrf52_support.c Refactored interrupt handling and critical sections, including renaming and changing variable types.
.../platform/impl/CMakeLists.txt Added a macro to apply preprocessor definitions based on defined variables.

[!TIP]

Early access features: enabled We are currently testing the following features in early access: - **OpenAI `gpt-4o` model for code reviews and chat**: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available. Note: - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file. - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues. - OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
lhstrh commented 4 days ago

@edwardalee what should we do with this PR? Include it in 0.8.0 or not?

edwardalee commented 4 days ago

Yes, let's merge this. It needs an approving review. There is still work to do, but it is now usable. There is a PR in the lf-lang web page to point to this capability.