Bugfixes in decentralized coordination

lf-lang / reactor-c

A reactor runtime written in C

Other

12 stars 24 forks source link

Bugfixes in decentralized coordination #476

Closed edwardalee closed 3 months ago

edwardalee commented 3 months ago

This PR fixes a number of issues with STA and STAA in decentralized coordination. There is a companion PR in lingua-franca. In particular:

It enables using large values when the data flow is predictable.
It changes terminology to use STA and STAA.
It guards against overflow of time values, allowing large STA and STAA.
It ensures that STA is always added to STAA.
It moves the logic of whether to add the STA out of wait_until and into the federated code.
It makes sure the stop tag is completed before exiting.

lhstrh commented 3 months ago

There are non-deterministic failures lurking somewhere. The CI run based https://github.com/lf-lang/reactor-c/pull/476/commits/21dee16522bcc9843dd0d18e9bca71bed3081ed4 failed, but the subsequent run based on https://github.com/lf-lang/reactor-c/pull/476/commits/89b0e3617db1d2730552a418fd35f1395afe114a passed, even though that commit only includes comments...

edwardalee commented 3 months ago

There are non-deterministic failures lurking somewhere. The CI run based 21dee16 failed, but the subsequent run based on 89b0e36 passed, even though that commit only includes comments...

No, this branch points to a branch of limgua-franca, which changed. So this is not a nondeterministic failure.