search

lf-lang / reactor-rs

Reactor runtime implementation in Rust
MIT License
9 stars 5 forks source link

Properly merge RContextForwardableStuff #12

Closed jhaye closed 2 years ago

jhaye commented 2 years ago

This is a quick fix for #4. Previously ctx.insides were replaced after executing a tag, instead of merged. I have confirmed that this works, but won't have the time to do proper performance testing for some time. Better working with potentially bad performance than broken I guess.

Closes #4

jhaye commented 2 years ago

Thanks for the suggestions!

jhaye commented 2 years ago

Yes, I think this terminology makes sense :+1:

codecov-commenter commented 2 years ago

Codecov Report

Merging #12 (315befa) into main (dd7edda) will increase coverage by 0.91%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #12      +/-   ##
============================================
+ Coverage     33.58%   34.49%   +0.91%     
- Complexity      624      951     +327     
============================================
  Files           127      147      +20     
  Lines          6620     8871    +2251     
  Branches       1065     1662     +597     
============================================
+ Hits           2223     3060     +837     
- Misses         4138     5315    +1177     
- Partials        259      496     +237
Impacted Files Coverage Δ
org.lflang/src/org/lflang/graph/TopologyGraph.java 0.00% <0.00%> (-88.00%) :arrow_down:
...ng/src/org/lflang/generator/ParameterInstance.java 30.76% <0.00%> (-24.24%) :arrow_down:
...lflang/src/org/lflang/generator/TimerInstance.java 57.14% <0.00%> (-9.53%) :arrow_down:
...lang/src/org/lflang/generator/ReactorInstance.java 47.66% <0.00%> (-7.38%) :arrow_down:
...g.lflang/src/org/lflang/generator/TargetTypes.java 63.82% <0.00%> (-5.94%) :arrow_down:
org.lflang/src/org/lflang/JavaAstUtils.java 47.27% <0.00%> (-4.73%) :arrow_down:
...ang/src/org/lflang/generator/rust/RustGenerator.kt 65.51% <0.00%> (-2.91%) :arrow_down:
org.lflang/src/org/lflang/generator/Validator.java 22.22% <0.00%> (-1.78%) :arrow_down:
org.lflang/src/org/lflang/ModelInfo.java 31.57% <0.00%> (-1.76%) :arrow_down:
org.lflang/src/org/lflang/util/XtendUtil.java 0.00% <0.00%> (ø)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dd7edda...315befa. Read the comment docs.

cmnrd commented 2 years ago

Great! Thanks!