search

lf-lang / reactor-rs

Reactor runtime implementation in Rust
MIT License
9 stars 5 forks source link

Add clippy to CI #22

Closed jhaye closed 2 years ago

jhaye commented 2 years ago

This contains one last Clippy fix, a very simple clippy configuration so that we can keep the function structure we currently have and a CI configuration. The CI configuration merges the Clippy linting step with the formatting step and now uses Rust stable.

Closes #21.

codecov-commenter commented 2 years ago

Codecov Report

Merging #22 (6d0e6a2) into main (7cbd39a) will decrease coverage by 0.17%. The diff coverage is n/a.

@@             Coverage Diff              @@
##               main      #22      +/-   ##
============================================
- Coverage     24.84%   24.66%   -0.18%     
+ Complexity     1017     1014       -3     
============================================
  Files           186      186              
  Lines         13136    13196      +60     
  Branches       2530     2542      +12     
============================================
- Hits           3263     3255       -8     
- Misses         9327     9395      +68     
  Partials        546      546
Impacted Files Coverage Δ
...rc/org/lflang/generator/ReactionInstanceGraph.java 82.72% <0.00%> (-5.67%) :arrow_down:
....lflang/src/org/lflang/generator/c/CGenerator.java 0.00% <0.00%> (ø)
....lflang/src/org/lflang/generator/ts/TSGenerator.kt 0.00% <0.00%> (ø)
...lflang/src/org/lflang/generator/python/PyUtil.java 0.00% <0.00%> (ø)
...lflang/src/org/lflang/generator/ts/TSExtensions.kt 0.00% <0.00%> (ø)
...ng/src/org/lflang/generator/c/CCoreFilesUtils.java 0.00% <0.00%> (ø)
...g/src/org/lflang/generator/c/CDockerGenerator.java 0.00% <0.00%> (ø)
...g/src/org/lflang/generator/ts/TSActionGenerator.kt 0.00% <0.00%> (ø)
...g/src/org/lflang/generator/ts/TSDockerGenerator.kt 0.00% <0.00%> (ø)
.../src/org/lflang/generator/DockerGeneratorBase.java 0.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7cbd39a...6d0e6a2. Read the comment docs.

jhaye commented 2 years ago

Apparently stable clippy panics on this code base. I don't know why, but switching to nightly made it work.