Remove ioctl from TcpIpChannel

lf-lang / reactor-uc

A lightweight reactor runtime targeted at resource-constrained embedded systems

BSD 2-Clause "Simplified" License

2 stars 2 forks source link

Remove ioctl from TcpIpChannel #59

Closed LasseRosenow closed 2 weeks ago

LasseRosenow commented 2 weeks ago

This changes the TcpIpChannel implementation in the following way

ioctl.h => sys/select.h
Use unistd.h for close instead of shutdown, which is not available in RIOT

The rationale behind this is to improve compatibility with platforms such as zephyr or RIOT which don't have full POSIX support.

This PR is a draft because I didn't have time to test it yet. There might be implementation bugs.

(I had some problems with compiling the example applications in examples/posix)

erlingrj commented 2 weeks ago

Great to see that you are already contributing code Lasse. I think the CI ight fail because the PR is coming from your fork. Could you try just filing it from a branch in this repo. I think you have the necessary access.

LasseRosenow commented 2 weeks ago

It seems you are correct, I will close this in favor of #61