search

lf-lang / vscode-lingua-franca

Lingua Franca extension for Visual Studio Code
Other
4 stars 3 forks source link

Diagram bug fixed #116

Closed petervdonovan closed 1 year ago

petervdonovan commented 1 year ago

This partially reverts commit f85abfc1bc5b634ca4bfa6286017ef859afc8f03.

This fixes #113.

Thank you to @soerendomroes for helping us find the source of the problem.

lhstrh commented 1 year ago

Looks like the fix introduced another problem...

petervdonovan commented 1 year ago

Why did this have to be changed? We use prepare-build-env almost everywhere, so it should just work...

There is an error due to the CWD being vscode-lingua-franca instead of lingua-franca during the cleanup process at the end. See this test failure (in main) for example.

What's the nature of the changes in the known-good texts?

I updated the lingua-franca submodule, so the content of the tests changed.

lhstrh commented 1 year ago

Why did this have to be changed? We use prepare-build-env almost everywhere, so it should just work...

There is an error due to the CWD being vscode-lingua-franca instead of lingua-franca during the cleanup process at the end. See this test failure (in main) for example.

I see. It's a bit mysterious as to why this error cropped up all of a sudden, but the workaround is fine with me.

What's the nature of the changes in the known-good texts?

I updated the lingua-franca submodule, so the content of the tests changed.

:+1:

petervdonovan commented 1 year ago

Probably the Windows error was related to the caching improvements. It's the only recent change that I was aware of.