search

lf-lang / vscode-lingua-franca

Lingua Franca extension for Visual Studio Code
Other
5 stars 3 forks source link

Strange rendering artifacts in diagrams #31

Closed lhstrh closed 2 years ago

lhstrh commented 2 years ago

image

a-sr commented 2 years ago

This is a discrepancy in the handling of the background color on edges between Klighd's rendering in Eclipse and VSC. LF PR #1063 adds a workaround.

lhstrh commented 2 years ago

I've seen a similar problem in the rendering of highlighted cycles in VS Code. Would this fix resolve that, too?

a-sr commented 2 years ago

No, the workaround does not resolve the issue in cycle highlighting yet. I will try to implement a fix for that too and add it to the PR.

a-sr commented 2 years ago

Ok, I included a fix for cycle highlighting in the PR as well. However, I only checked that there is no background color set on the edges (which apparently causes the problem), I could not check the result in VSC because I currently don't have a working setup. You may want to confirm that the rendering artifacts are gone. Or just merge the PR in good hope.

lhstrh commented 2 years ago

I've checked with the v1.0.1 release candidate, which is built against the v0.1.0 release candidate (up-to-date with master currently), but the issue still persists:

image

lhstrh commented 2 years ago

Same with the cycle highlighting: image

lhstrh commented 2 years ago

Has been solved in v0.1.1 release.