search

lf-lang / vscode-lingua-franca

Lingua Franca extension for Visual Studio Code
Other
4 stars 3 forks source link

`npm install` installs the first `.vsix` file it can find rather than the one it produced #73

Closed lhstrh closed 2 years ago

lhstrh commented 2 years ago

Because we use a wildcard when finding the .vsix file, if there is a previously built version, that version gets installed instead of the latest.

petervdonovan commented 2 years ago

The previously built VSIX should be deleted by npm install in the clean step. Did you observe this issue on the current version of main?

It should be easy to fix this by finding the latest version, but I just want to double check so that we don't do redundant work.

lhstrh commented 2 years ago

Yes, I observed it on the current version of main.

On Fri, Jul 22, 2022 at 3:47 PM Peter Donovan @.***> wrote:

The previously built VSIX should be deleted by npm install in the clean step https://github.com/lf-lang/vscode-lingua-franca/blob/fd6c80a540a380a4fc7ff2b4ab5dbd8081875681/package.json#L152. Did you observe this issue on the current version of main?

It should be easy to fix this by finding the latest version, but I just want to double check so that we don't do redundant work.

— Reply to this email directly, view it on GitHub https://github.com/lf-lang/vscode-lingua-franca/issues/73#issuecomment-1192987778, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEYD47HERF25BLFF7D6ODXTVVMQIDANCNFSM54M3PJ3A . You are receiving this because you authored the thread.Message ID: @.***>