search

lf1-io / padl

Functional deep learning
Apache License 2.0
106 stars 4 forks source link

452 pydev warning #455

Closed wuhu closed 2 years ago

wuhu commented 2 years ago

Description

Pydev doesn't like other packages to use sys.settrace and warns about it due to the danger that it may interfere with the pydev debugger. This is explained here: https://pydev.blogspot.com/2007/06/why-cant-pydev-debugger-work-with.html. I've checked if debugging is affected - it is not - and replaced sys.settrace by pydevd_trace.SetTrace if available as suggested in one of the above page's comments. This supresses the warning.

Fixes #452

codecov-commenter commented 2 years ago

Codecov Report

Merging #455 (e3078f9) into main (3694028) will increase coverage by 0.01%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
+ Coverage   89.04%   89.06%   +0.01%     
==========================================
  Files          15       15              
  Lines        3004     3008       +4     
==========================================
+ Hits         2675     2679       +4     
  Misses        329      329
Impacted Files Coverage Δ
padl/dumptools/inspector.py 92.89% <66.66%> (+0.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1dfa150...e3078f9. Read the comment docs.