lfd / PaStA

The Patch Stack Analysis
GNU General Public License v2.0
33 stars 20 forks source link

Detect and visualise mismatch #30

Closed tapaswenipathak closed 5 years ago

tapaswenipathak commented 5 years ago

Fixes #20

Please find more info below:

pasta

tapaswenipathak commented 5 years ago

Thanks for the brain dump; the PR is in draft state, I appreciate your comments, I will tag for review.

rralf commented 5 years ago

Hi Tapasweni,

thanks for the draft! Please try to align with other PaStA tools. I'd like to start tools with ./pasta toolname arguments.

Last week, I implemented a MAINTAINERS interface for PaStA. Please try to use it instead of calling get_maintainers.pl (it's known to be pretty slow). I'm happy to accept patches for the interface (I'm sure there are still some incomplete or odd things).

Thanks Ralf

rralf commented 5 years ago

Ah, I forgot one thing: You need to use the MAINTAINERS file at the moment the commit was accepted, as the MAINTAINERS underlies frequent changes.

This makes things a bit harder. It should be good enough if look at the MAINTAINERS file of the closest release. Here https://github.com/lfd/PaStA/commit/1d6dfd0f45c5f9adaaac81bfa60e889dcdb5c973#diff-1d0541a8ccacc43136fd8d7eb48424c6R401 you can find an example how we load the maintainers file (please ignore the rest of the code, this is a WIP branch).

tapaswenipathak commented 5 years ago

Hi @rralf:

Just getting hang of the project for tackling with everything else. Thanks for the brain dump, appreciate your comments; I will tag for review.