Closed tapaswenipathak closed 5 years ago
Thanks for the brain dump; the PR is in draft state, I appreciate your comments, I will tag for review.
Hi Tapasweni,
thanks for the draft! Please try to align with other PaStA tools. I'd like to start tools with ./pasta toolname arguments.
Last week, I implemented a MAINTAINERS interface for PaStA. Please try to use it instead of calling get_maintainers.pl (it's known to be pretty slow). I'm happy to accept patches for the interface (I'm sure there are still some incomplete or odd things).
Thanks Ralf
Ah, I forgot one thing: You need to use the MAINTAINERS file at the moment the commit was accepted, as the MAINTAINERS underlies frequent changes.
This makes things a bit harder. It should be good enough if look at the MAINTAINERS file of the closest release. Here https://github.com/lfd/PaStA/commit/1d6dfd0f45c5f9adaaac81bfa60e889dcdb5c973#diff-1d0541a8ccacc43136fd8d7eb48424c6R401 you can find an example how we load the maintainers file (please ignore the rest of the code, this is a WIP branch).
Hi @rralf:
Just getting hang of the project for tackling with everything else. Thanks for the brain dump, appreciate your comments; I will tag for review.
Fixes #20
./scripts/get_maintainer.pl <file_name>
for the patch.Please find more info below: