Refactor if/else ladder to make it more readable

lfd / PaStA

The Patch Stack Analysis

GNU General Public License v2.0

33 stars 20 forks source link

Closed rsarky closed 4 years ago

rsarky commented 4 years ago

Refactor the if else logic to appropriately fail if succ argument is passed in mbox mode

Fixes #44

rsarky commented 4 years ago

updated the commit message!

rralf commented 4 years ago

Thanks for the PR! But that's a pretty invasive refactoring. I'll have to test and review carefully. Will do that tomorrow. Thank you!

rralf commented 4 years ago

Rebased, and applied to next, with minor stylistic changes. Thanks Rohit!

rralf commented 4 years ago

Ok, github is strange. I manually applied the patch to next, and now github thinks I rejected you patch. This is of course not the case.

rralf commented 4 years ago

Ah, and nice refactoring. It's really easier to read now.