search

lfd / PaStA

The Patch Stack Analysis
GNU General Public License v2.0
33 stars 20 forks source link

Refactoring aggregation analyses #60

Closed anmolsingh20 closed 4 years ago

anmolsingh20 commented 4 years ago

Hi Ralf, could you please have a look. I will probably need to rebase again, but it is a moving target, so will do after a review. There is an additional pull request on the resources repo to complete this change.

rralf commented 4 years ago

Hi Anmol, I rebased to next, and accepted both patches. For the second one, I referenced the new commit hash of the resources submodule, and removed all changes that are not related to the change of the location of the configuration. The reason: I don't understand why you import pandas, flat_table or dask. There are currently no users of those libraries.

anmolsingh20 commented 4 years ago

Hi Anmol, I rebased to next, and accepted both patches. For the second one, I referenced the new commit hash of the resources submodule, and removed all changes that are not related to the change of the location of the configuration. The reason: I don't understand why you import pandas, flat_table or dask. There are currently no users of those libraries.

I missed removing those imports while rolling back some other changes, so it is good that you removed them. They will follow in the next patch. Thanks!