search

lferry007 / LargeVis

Apache License 2.0
708 stars 168 forks source link

Make module Python3 compatible. #25

Open lmcinnes opened 7 years ago

lmcinnes commented 7 years ago

The python module is compatible only with Python2. I have made the minor necessary changes to simultaneously support both Python3 and Python2.

wlbksy commented 7 years ago

it works

LGro commented 7 years ago

Thanks for the efforts. Compiling with gcc (GCC) 4.8.5 and installing under Python 3.6.2 :: Continuum Analytics, Inc. I get the following error on import:

ImportError: dynamic module does not define module export function (PyInit_LargeVis)

The solution to this seems to be renaming the function PyInit_myextension(void) in LargeVismodule.cpp:171 to PyInit_LargeVis(void), alongside with the matching change in line 158, where it also still says myextension. @lmcinnes can you validate this and update your pull request?