search

lferry007 / LargeVis

Apache License 2.0
706 stars 167 forks source link

Documentation & Acknowledgment #4

Closed DataWaveAnalytics closed 7 years ago

DataWaveAnalytics commented 8 years ago

Hi,

First, thank you for sharing this implementation of LargeVis. I like the idea of having simple code doing a complex computation. In saying that, it would be great if you can include documentation to the source. This would help to improve or extend the source.

Also, I can see that some of the methods have been taken from a previous work of the original authors of LargeVis https://github.com/tangjianpku/LINE with minors C++ modifications. In my opinion, you should acknowledge that fact in the documentation as well.

Regards

lferry007 commented 8 years ago

Hi. I have added acknowledgement, and I am still working on documentations. All kinds of improving and extending will be welcomed!

DataWaveAnalytics commented 8 years ago

Thank you @lferry007.

I've been exchanging some messages with the creator of annoy. He is interested in using the idea of "neighbors of my neighbors", but he needs to understand the idea first. I think you guys should work together to improve both sides :)

Please, check the last 4 messages in this thread: https://groups.google.com/forum/#!topic/annoy-user/RIGqI_pvhTs

lferry007 commented 8 years ago

Thanks @csanhuezalobos for pointing this out. I've communicated with the creator of annoy. For now, it seems very hard to apply the idea of "neighbors of my neighbors" into Annoy. The reason is that Annoy aims to solve the problem of real-time nearest neighbor search, which aims to find the nearest neighbors given a query data point. For our problem, we aim to build the k-nearest neighbor graph, which aims to find the nearest neighbors for all the data points. The idea of "neighbors of neighbors" can only be used when a K-nearest neighbor graph is constructed.

Jian https://sites.google.com/site/pkujiantang/home