search

lfex / kanin

An LFE Wrapper for the Erlang RabbitMQ (AMQP) Client
Apache License 2.0
7 stars 2 forks source link

Rebar 3 support #1

Closed arpunk closed 8 years ago

arpunk commented 8 years ago

This removes the old Makefiles and manual AMQP library installation in favor of rebar3 based compilation.

It also bumps the libraries to the latests published versions.

oubiwann commented 8 years ago

Wow, this looks great -- thanks!

One request, and then I'll merge: could you re-add the lfe.config file? (but you can remove the depss config directive).

Eventually, lfe projects won't have a src/*.app.src, but instead one will be generated for them from their lfe.config file. I think there's only one project that does that right now, but more will be able to do it easily once the lcfg rebar3 plugin is made ...

arpunk commented 8 years ago

@oubiwann Sure thing. I was under the impression lcfg was only used for skipping rebar dependencies and this is now handled properly with rebar3. Do you plan to just translate the metadata file to the .app.src file?

oubiwann commented 8 years ago

Yeah, the project that is currently generating it's .app.src file using lcfg does just that: writes the metadata out in Erlang syntax, having read it from its lfe.config file.

oubiwann commented 8 years ago

Thanks again!

oubiwann commented 8 years ago

Whoops -- I pulled the trigger too quickly!

arpunk commented 8 years ago

It's ok, I will file up a new PR with the missing stuff by the end of the day.