fixes issue #244: Removed duplicate entries and replaces 0xXXX with valid random hex codes - Githubissues

lfglabs-dev / api.starknet.quest

starknet.quest rust backend

7 stars 28 forks source link

fixes issue #244: Removed duplicate entries and replaces 0xXXX with valid random hex codes #246

Closed SoarinSkySagar closed 2 months ago

SoarinSkySagar commented 2 months ago

This Pull Request is for resolving issue #244. There are no more issues regarding the invalid hex codes now. Here's the checklist for the PR:

[x] Fix issues such as the "[rhino]" or "[pyramid]" categories which are present twice
[x] Replace template Hex values such as "0xXXXXXXXXXXXX" which are not numbers as it's only composed of "XXX..." by random Hex values such as "0xFFFFF"
[x] Check there are no other parsing errors

This PR has been done as part of OnlyDust's ODHack 7.0.

SoarinSkySagar commented 2 months ago

Hi @Marchand-Nicolas , I was assigned the issue for OnlyDust's ODHack 7.0, and here is the PR resolving that issue. Please review and merge or request the required changes if required.

SoarinSkySagar commented 2 months ago

GM @Marchand-Nicolas, thanks for pointing it out! I have fixed it now, can you check it?