lfglabs-dev / api.starknet.quest

starknet.quest rust backend
3 stars 20 forks source link

Fix create_boost.rs #287

Open Marchand-Nicolas opened 4 days ago

Marchand-Nicolas commented 4 days ago

In src/endpoints/admin/quest_boost/create_boost.rs, line 38, the collection should be "tasks" and not "quests". (Because we already get the quests collection on the upper line).

ShantelPeters commented 4 days ago

Hi @Marchand-Nicolas can i please be assigned to this issue?

mubarak23 commented 4 days ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hi I am an Experience Cairo smart contract developer with experience working on projects such as Just Art Peace, Dojo, Kart, TBA, and Shinigami. Before transitioning to Cairo development, I was a backend developer specializing in Rust.

How I plan on tackling this issue

CHANGE this

let insert_collection = state.db.collection::<QuestTaskDocument>("quests");

to this

let insert_collection = state.db.collection::<QuestTaskDocument>("tasks");

ETH: 1hour

@Marchand-Nicolas

PoulavBhowmick03 commented 4 days ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I'm Poulav Bhowmick, a software engineer at Invisible Studios with a robust background in TypeScript, Rust, Solidity Cairo, fullstack development and blockchain technology. My experience includes building robust applications, optimizing functionalities and blockchain integration. I have actively participated in events and open source contributions, enhancing my capability to tackle real-world tech challenges. My projects can be viewed on my GitHub Profile and OnlyDust Profile. Plus I´m active member of Starknet, Ethereum ecosystem.

How I plan on tackling this issue

I have a good experience of the Starknet quest api repository and have made previous contribution I can fix this issue by changing the collection to 'tasks instead of quests'

let insert_collection = state.db.collection::<QuestTaskDocument>("quests");

I will change it to

let insert_collection = state.db.collection::<QuestTaskDocument>("tasks");

ETA- 1 day

sajalbnl commented 4 days ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I have 2 years of experience as a front-end developer, with expertise in JavaScript, React.js, CSS, and HTML. I've built full-stack projects like Crypto Bank, handling both front-end and back-end development. My skills in creating responsive, dynamic interfaces make me well-equipped to contribute effectively to your project.

Benjtalkshow commented 4 days ago

@Marchand-Nicolas Can I be assigned to this task? I will quickly fix this bug. My ETA is 24hrs. Thanks

0xdevcollins commented 4 days ago

Can I be assigned this issue? I will make a PR within 24hrs

fishseabowl commented 4 days ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a blockchain full-stack developer and have contributed to numerous open-source projects, including StarkNet.quest.

How I plan on tackling this issue

Based on the comments, II will update line 38 and the related code, then run tests on the changes. I believe it should be completed in about a hour.

JosueBrenes commented 4 days ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hi, I'm Josué Brenes and I'll be working on issue. I'm Dojo Coding member.

I estimate this will take 1 day to complete.

How I plan on tackling this issue

Update the collection reference

The issue occurs because the code mistakenly references the wrong collection ("quests") in create_boost.rs. I will modify the collection reference to "tasks" to match the intended behavior.

  let insert_collection = state.db.collection::<QuestTaskDocument>("tasks");  

Run tests and validation

I will run the appropriate tests to ensure the fix works as expected and that the correct collection is used in all relevant operations.

joeperpetua commented 4 days ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

3+ years doing full stack dev

zleypner commented 4 days ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

How I plan on tackling this issue

3+ years Front End developer experience

Gerson2102 commented 1 day ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hey! I'm Gerson. 👋

Member of Dojo Coding. I have contributed before to other Rust based projects like:

Can I work on this issue?

Check my OnlyDust profile, I've contributed to many projects: Profile


How I plan on tackling this issue

Plan to Solve the Issue:

  1. Study the codebase to understand the current structure and functionality.
  2. Understand the problem that needs to be solved by thoroughly reading the issue details.
  3. Leverage all provided resources within the issue to get a better grasp of the task at hand.
  4. If I encounter roadblocks, I will ask questions ASAP in the Telegram group to move forward effectively.
  5. I will open a PR and wait for ur feedback

I will change this on the base code:

let insert_collection = state.db.collection::<QuestTaskDocument>("quests");

to this:

let insert_collection = state.db.collection::<QuestTaskDocument>("tasks");