Refactor/pricing

[Th0rgal]

This pull request refactors the way prices are computed. It is based on an old version of the branch by @Marchand-Nicolas adding the argent discount, we might need to rebase it.

• Use of bigint: Replaced mix of strings and numbers with bigint for price computations.
• String Usage: Only used strings for variables that are displayed; computations remain in bigint.
• Allowance Calculation Bug Fix: Fixed the bug with allowance not being proportional to the number of domains renewed.
• Sales Tax in Renewal Allowances: Included sales tax in renewal allowance calculations.
• State Management: Consolidated state variables related to pricing and simplified sales tax logic.
• Currency Switching: Improved onCurrencySwitch for clearer and concise handling.
• Renewal Price Calculation: Added logic to calculate yearly renewal prices, including taxes

Files Affected:

• components/CheckoutCard.tsx
• components/RegisterSummary.tsx
• components/RegisterCheckboxes.tsx

We still need to test:

• If user balance is not big enough, it automatically switches (I couldn't test in local)
• Renewals

And to update:

• Various discounts

Summary by CodeRabbit

• New Features

  • Enhanced wallet connection logic for better handling of connectors based on availability and platform.
  • Improved discount and renewal components with more precise calculations and streamlined props.

• Bug Fixes

  • Adjusted useEffect dependencies across multiple components to ensure correct hook execution.

• Style

  • Updated styling in discount module to improve layout and spacing.

• Performance Improvements

  • Switched to using bigint for more accurate and efficient price calculations.

• Updates

  • Bumped starknetid.js version from 3.2.0 to 3.2.2.
  • Replaced getPriceFromDomains with getManyDomainsPriceWei for better performance in pricing calculations.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
app-starknet-id	❌ Failed (Inspect)			Jul 16, 2024 3:31pm
sepolia-app-starknet-id	❌ Failed (Inspect)			Jul 16, 2024 3:31pm

[coderabbitai[bot]]

Walkthrough

This update involves significant refactoring across several components, focusing on improving accuracy and efficiency in pricing calculations, currency handling, and state management. Key changes include the adoption of the bigint type for precise calculations, updates to state variables and props, and the integration of the useRouter hook for navigation handling. The update also includes enhancements to UI components, especially those related to registration, renewal, and discounts, resulting in a more robust and user-friendly application.

Changes

Files	Change Summary
components/UI/iconsComponents/icons/...	Removed color prop from CloseFilledIcon and PyramidIcon components, simplifying their function signatures.
components/UI/walletConnect.tsx	Added useRouter hook and new functions (openBraavosMobile, needInstall, tryConnect) to enhance wallet connection handling.
components/discount/freeRenewalDiscount.tsx	Refactored FreeRenewalCheckout by streamlining props and adopting bigint for precise calculations, updated effects and state variables.
components/discount/registerDiscount.tsx	Refactored RegisterDiscount, updated state variables, useEffect hooks, and removed TxConfirmationModal.
components/domains/autorenewal.tsx	Updated state management and pricing logic, replaced getPriceFromDomains with getManyDomainsPriceWei.
components/domains/registerCheckboxes.tsx	Changed gweiToEth to weiToEth, removed ethRenewalPrice prop.
components/domains/registerSummary.tsx	Updated props to use bigint, adjusted logic for price calculations and display, removed some props.
components/domains/registerV3.tsx	Updated duration to durationInYears in updateFormState function.
components/domains/renewalV2.tsx	Updated dependencies for updateFormState and changed duration to durationInYears.
components/domains/steps/checkoutCard.tsx	Modified state variables and calculations related to pricing, taxes, and currency selection, updated useEffect hooks.
components/domains/steps/userInfoForm.tsx	Renamed duration to durationInYears, updated state update functions and useEffect hook.
components/identities/actions/identityActions.tsx	Expanded useEffect dependencies to include address, identity, and starknetIdNavigator.
package.json	Updated "starknetid.js" version from ^3.2.0 to ^3.2.2.
pages/_app.tsx	Modified MyApp function, removing solNetwork argument from the array.
pages/discord.tsx	Modified useEffect hook dependencies to ensure it runs only when the transaction is sent.
pages/gift.tsx	Removed customMessage prop from FreeRegisterCheckout component.
pages/github.tsx	Modified useEffect hook to run only when the transaction hash is present.
pages/identities.tsx	Added comment and disabled lint rule for a specific line in a React functional component.
pages/twitter.tsx	Removed import and usage of useWaitForTransaction, refactored verifyTwitter function, adjusted dependencies.
styles/discount.module.css	Added margin-left: 1rem; and margin-right: 1rem; to .descriptionVariant class.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[fricoben]

working on it here https://github.com/starknet-id/app.starknet.id/pull/874