ref: Reactor register/pricing/discounts

fricoben commented 2 months ago

Description

Adding pricing variables related in bigint everywhere before displaying it
Change duration in days everywhere it makes sense
Take into consideration old approval while registering, if the approval is not infinite we add up the approval (one 10Y approval per domain)

My E2E

[x] /Register in both currencies
- [x] USD display bug
- [x] Sales tax discount bug calculation
- [x] Altcoin buy duration bug
[x] /Renew in both currencies
[x] /gift
[x] /subscription in both currencies
[x] /freerenewal in both currencies

Summary by CodeRabbit

New Features
- Enhanced clarity in duration handling by renaming properties from duration to durationInDays or durationInYears across multiple components.
- Introduced bigint type for monetary values, improving precision in financial calculations.
- Added new functions for pricing calculations, including getDisplayablePrice and getApprovalAmount.
- Introduced a Notification component for user feedback on token quote retrieval failures.
- Added a custom hook useCurrencyManagement for managing currency selection and fetching token quotes.
Bug Fixes
- Corrected import paths and consolidated props in components for better maintainability.
Documentation
- Updated type definitions to reflect changes in property names and types for better clarity.
Refactor
- Streamlined state management and logic in various components to enhance readability and performance, including the use of hooks and memoization.
Chores
- Removed unused functions and optimized existing ones for improved functionality and clarity.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
app-starknet-id	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 2, 2024 0:19am
sepolia-app-starknet-id	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 2, 2024 0:19am

coderabbitai[bot] commented 2 months ago

Walkthrough

The changes across the codebase involve renaming properties for clarity, particularly changing duration to durationInDays or durationInYears. Additionally, monetary values have shifted from string types to bigint for improved precision in financial calculations. Several functions have been renamed or restructured to align with these updates, and some components have consolidated their props into single objects for better management. A new custom hook for currency management has also been introduced.

Changes

Files	Change Summary
components/discount/freeRegisterCheckout.tsx, components/discount/freeRegisterSummary.tsx, components/discount/registerDiscount.tsx, components/discount/freeRenewalCheckout.tsx, components/domains/autorenewal.tsx, components/domains/registerCheckboxes.tsx, components/domains/registerSummary.tsx, components/domains/registerV3.tsx, components/domains/renewalV2.tsx, context/FormProvider.tsx	Renamed `duration` to `durationInDays` or `durationInYears` across multiple components. Changed monetary types from `string` to `bigint`.
components/discount/freeRenewalCheckout.tsx, components/discount/registerDiscount.tsx, components/domains/registerSummary.tsx	Consolidated props into single objects for certain components, improving clarity.
components/identities/actions/clickable/clickablePersonhoodIcon.tsx	Removed import of `constants` from `starknet`.
hooks/useAllowanceCheck.tsx, hooks/useNeedAllowances.tsx	Updated return types and state management to reflect changes in allowance handling, introducing `AllowanceStatus` type.
utils/feltService.ts, utils/subscriptionService.ts	Modified functions to accept `bigint` instead of `string` for monetary values, enhancing precision in calculations.
pages/argent.tsx	Simplified components by removing state management and conditional rendering, directly rendering static screens instead.
utils/constants.ts	Updated the value of `swissVatRate` from `0.077` to `0.081`.
utils/discounts/freeRegistration.ts, utils/discounts/freeRenewal.ts	Changed `price` from string to `BigInt(0)` and renamed `duration` to `durationInDays`.
tests/utils/altcoinService.test.js, tests/utils/feltService.test.js	Updated tests to utilize `BigInt` for numerical calculations instead of strings.
types/frontTypes.d.ts	Renamed properties in various types to improve clarity and specificity, particularly around monetary values.
hooks/checkout/useCurrencyManagement.tsx	Introduced a new custom hook for managing currency selection and fetching token quotes.

Sequence Diagram(s)

sequenceDiagram
    participant A as User
    participant B as Currency Management Hook
    participant C as Token Quote Service

    A->>B: Select currency
    B->>C: Fetch token quote
    C-->>B: Return quote data
    B-->>A: Display quote

This diagram illustrates the interaction between the user and the new currency management hook, highlighting the process of selecting a currency and fetching the corresponding token quote.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

Early access features: disabled

We are currently testing the following features in early access: - **Anthropic `claude-3-5-sonnet` for code reviews**: Anthropic claims that the new Claude model has stronger code understanding and code generation capabilities than their previous models. Note: Our default code review model was also updated late last week. Please compare the quality of the reviews between the two models by toggling the early access feature. Note: - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file. - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues on the [discussion post](https://discordapp.com/channels/1134356397673414807/1279579842131787838).

lfglabs-dev / app.starknet.id