search

lfglabs-dev / starknet.quest

The on-chain quest tool of Starknet
https://starknet.quest
33 stars 119 forks source link

Add shimmer on leaderboard on first load #524

Closed ayushtom closed 7 months ago

ayushtom commented 8 months ago

When the user comes on the leaderboard page, we make some api calls to get the latest leaderboard data and in that time when this call is made , the user is able to see the leaderboard but nothing indicates that we are fetching data. I think a loading state like a shimmer should help here which takes up a certain height and is displayed until we get the data. A similar implementation of this shimmer is seen when you change the page with the help of the pagination buttons below but it would be nice if we showed the shimmer when the user lands on the page for the first time.

The code for example shimmers can be found under the skeletons folder photo_2024-03-07_21-27-23

Goodness5 commented 8 months ago

Assign this task to me

ayushtom commented 8 months ago

Assigned!

Goodness5 commented 8 months ago

on it....

Goodness5 commented 8 months ago

can i get mock data for this apparently without any data available some components won't be displayed

ayushtom commented 7 months ago

you can use the goerli endpoint and use it in your env file

fricoben commented 7 months ago

can i get mock data for this apparently without any data available some components won't be displayed

@Goodness5 waiting for your PR on this or issue will go to someone else :)

Goodness5 commented 7 months ago

Done here is a link to the PR https://github.com/starknet-id/starknet.quest/pull/551