lfglabs-dev / starknet.quest

The on-chain quest tool of Starknet
https://starknet.quest
34 stars 128 forks source link

Implement new loading everywhere #855

Open fricoben opened 1 month ago

fricoben commented 1 month ago

Description

This issue is linked to https://github.com/lfglabs-dev/starknet.quest/issues/853 once this is done we'll need to populate the change to the whole codebase by:

This will need some time and patience, be rigorous and you'll be rewarded! If I have to test again all skeletons when I review go back and forth ... the reward will be smaller.

I'll wait for @Ugo-X to finish :)

martinvibes commented 1 month ago

hello @fricoben please kindly assign :) i would love to take on this issue and get it done

Kaminar-i commented 1 month ago

hey man @fricoben can i work on this

NueloSE commented 1 month ago

@fricoben can i be assigned this task

petersdt commented 1 month ago

@fricoben kindly assign me this task

Ugo-X commented 1 month ago

@fricoben Please can I be assigned this issue? Will be sure to deliver a good job

Benjtalkshow commented 1 month ago

@fricoben Please i am willing and ready to work on this.

0xdevcollins commented 1 month ago

Hi @fricoben , could you please assign this issue to me? I’ll make sure to deliver quality work.

Benjtalkshow commented 1 month ago

Hello @fricoben , can i work on this?

Samrath49 commented 1 month ago

Hey, there @fricoben I have checked the wrapper component, and once it's done I can take this task. I understand the requirement and it will be better to have an HOC that will streamline the process of displaying loading UI through the application and with consistent styles. If we need to I can also work on the wrapper component.

josephchimebuka commented 1 month ago

Hello @fricoben can I work on this. I would love the opportunity to solve this issue

Ugo-X commented 1 month ago

@fricoben Please can I be assigned this issue? I will be sure to deliver quality work and I understand the issue better from the previous one just merged.

od-hunter commented 1 month ago

Hi @fricoben , please can I be assigned this issue?

Benjtalkshow commented 1 month ago

@fricoben Can i work on this task? My ETA is 24hrs. thanks

lauchaves commented 1 month ago

Hey! @fricoben Mind if I give this one a try? I've already reviewed the new reusable loading component and am ready to apply it to the app. Let me know if that works for you! 😊

fishseabowl commented 1 month ago

Hi @fricoben could I work on this? I believe it should be completed in about a few hours. Thanks

wheval commented 1 month ago

Hello @fricoben.

I'm Wheval, a Frontend developer with solid experience in building clean and functional user interfaces. Here's how I would handle this, I would replace all the current customized skeletons with the new loading component implemented in #853 to ensure consistency across components. I would test the loader to ensure it works properly everywhere. Then, I would delete all non-used skeleton wrappers to prevent duplication. I would take my time to test it and ensure it works perfectly, to avoid back and forth. Thank you.

ETA is 3 days

OWK50GA commented 1 month ago

Hello, @fricoben, can I work on this issue? I am Wilfrid Okorie, a frontend web developer adept at creating intuitive UIs. Creating and animating loading skeletons for the different pages and components of the project.

Due to the size of the project, I will estimate 3 days to fix the issue

SoarinSkySagar commented 3 weeks ago

Hi @fricoben, I will run a search across the entire codebase for the current customized skeleton new standard loading wrapper, and replace them all with the loading wrapper created in the mentioned issue. I will then make sure that all UI works in the pages as expected, and remove all unused imports of the skeleton wrapper

ETA: 3 days

Benjtalkshow commented 3 weeks ago

@fricoben Can i work on this issue? My ETA is 2hrs. Thanks

SudiptaPaul-31 commented 3 weeks ago

Hello @fricoben

My approach to tackle this issue:

I wll locate all instances of the current customized skeleton components and will replace them with the new standardized loading wrapper to maintain consistency across the UI. After that I will carefully test each component on the UI to confirm the new loading visuals render correctly in every instance. Will go through the entire codebase to find any now-unused skeleton components and remove them

ETA-3days

AYo101o commented 2 weeks ago

@fricoben is this issue still needed? please can I be assigned this issue? Will be sure to deliver a good job

Yunusabdul38 commented 2 weeks ago

@fricoben I'd like to handle this task