lfglabs-dev / starknet.quest

The on-chain quest tool of Starknet
https://starknet.quest
33 stars 121 forks source link

refactor `profileCard.tsx` margin #865

Closed fricoben closed 1 month ago

fricoben commented 1 month ago

Description

refactor profileCard.tsx margin from

Capture d’écran 2024-10-08 à 18 08 31

to

Capture d’écran 2024-10-08 à 18 09 12

Proposed Changes

  1. Change the justification from justify-between to justify-center for better vertical alignment.
  2. Add a small margin (0.5rem) to the domain part to improve spacing.

Implementation Details

In the components/UI/profileCard/profileCard.tsx file, make the following changes:

  1. Modify the flex container for the profile information:

    From:

    <div className="flex flex-col h-full justify-between">

    To:

    <div className="flex flex-col h-full justify-center">
  2. Add margin to the domain (profile name) Typography component:

    From:

    <Typography type={TEXT_TYPE.H2} className={styles.profile_name}>{identity.domain.domain}</Typography>

    To:

    <Typography type={TEXT_TYPE.H2} className={`${styles.profile_name} mt-2`}>{identity.domain.domain}</Typography>

I'm not sure it works so make it work as the image.

Iwueseiter commented 1 month ago

Hi @fricoben can I work on this? I’m a frontend and smart contract developer and I’d get this done ASAP. Kindly assign.

ETA: 6hrs.

ShantelPeters commented 1 month ago

Hi @fricoben please i will like to work on this issue

0xdevcollins commented 1 month ago

Hello @fricoben Can i be assigned this task, i will deliver in 24hrs

fishseabowl commented 1 month ago

Hi @fricoben could I work on this? I believe it should be completed in about an hour.

DiegoB1911 commented 1 month ago

Hi! I am a Full Stack Developer with two years of experience, primarily working with Next.js, and I have also worked with Tailwind. I am an active member of Dojo Coding, where I am expanding my expertise in Cairo and Web3 technologies. I am enthusiastic about learning and contributing to this project.

To solve this issue, I would first try what you propose. I will change the justification from justify-between to justify-center in the flex container and add a small margin to the Typography component.

lauchaves commented 1 month ago

Hey, Ive been working on the profilecard, may I give this one a try?

martinvibes commented 1 month ago

hello @fricoben i would love to be the one to work on this issue :)

NueloSE commented 1 month ago

hi @fricoben can i be assigned this task

Kaminar-i commented 1 month ago

hello @fricoben please can i work on this issue? i would love to be a contributor

petersdt commented 1 month ago

good day @fricoben i would like to make this my first contribution to the starkquest project. kindly assign me. ETA 48hours

MatiasAchucarro commented 1 month ago

Hello @fricoben , how are you? I would love to take this issue as it would be my second contribution to Starknet Quest. I’m really motivated to keep learning and working with you, and I would be excited to continue contributing to the project.

fricoben commented 1 month ago

assigned @fishseabowl