search

lfglabs-dev / starknet.quest

The on-chain quest tool of Starknet
https://starknet.quest
33 stars 121 forks source link

Feat/add bitget wallet support #915

Closed jaiminRaiyani closed 2 weeks ago

jaiminRaiyani commented 2 weeks ago

This PR introduces support for the Bitget wallet in the Starknet Quest application. This includes updates to components and hooks to facilitate Bitget wallet integration and make it available for user selection.

Features :

app/provider.tsx: Added a new InjectedConnector instance for Bitget wallet, making it selectable from the available connectors list.

components/UI/changeWallet.tsx: Modified wallet change functionality to include the Bitget wallet in relevant button displays. Updated wallet selection conditions to recognize Bitget, ensuring it appears alongside existing wallets like Braavos and ArgentX.

components/UI/iconsComponents/icons/walletIcons.tsx: Added an SVG icon for Bitget wallet, ensuring consistent UI representation within the app.

hooks/useGetDiscoveryWallets.ts: Enhanced the useGetDiscoveryWallets hook to include Bitget wallet discovery and download link for easy access.

Resolves: #909

Other information

the svg icon for bitget might not work so do not consider that

Summary by CodeRabbit

Release Notes

vercel[bot] commented 2 weeks ago

@jaiminRaiyani is attempting to deploy a commit to the LFG Labs Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai[bot] commented 2 weeks ago

Walkthrough

The changes in this pull request introduce support for the Bitget Wallet in the application. A new InjectedConnector for Bitget is added to the availableConnectors array in app/provider.tsx, alongside a repositioning of the existing Keplr connector. The ChangeWallet component is updated to render a button for the new Bitget connector, and the WalletIcons component is modified to include an icon for Bitget. Additionally, the useGetDiscoveryWallets hook is updated to manage the download link for the Bitget wallet. Minor syntax adjustments are made in the configuration file.

Changes

File Change Summary
app/provider.tsx Added InjectedConnector for Bitget Wallet; repositioned Keplr connector.
components/UI/changeWallet.tsx Updated ChangeWallet to render button for Bitget; improved Typography formatting.
components/UI/iconsComponents/icons/walletIcons.tsx Added conditional rendering for Bitget icon in WalletIcons.
hooks/useGetDiscoveryWallets.ts Introduced bitkeep state variable for download link; updated return statement to include bitkeep.
next.config.js Removed trailing comma from images configuration for "www.starknet.id".

Assessment against linked issues

Objective Addressed Explanation
Add Bitget Wallet (#909) āœ…
šŸ“œ Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
šŸ“„ Commits Reviewing files that changed from the base of the PR and between bf8e14a1fcf6256c463ed1658a2780bce37249cb and ed21905b5110bc5486a804608fc41ec1b40c656d.
šŸ“’ Files selected for processing (1) * `app/provider.tsx` (2 hunks)
šŸš§ Files skipped from review as they are similar to previous changes (1) * app/provider.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

ā¤ļø Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
šŸŖ§ Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ā†—ļøŽ

Name Status Preview Comments Updated (UTC)
starknet-quest āœ… Ready (Inspect) Visit Preview šŸ’¬ Add feedback Oct 31, 2024 2:38pm
Marchand-Nicolas commented 2 weeks ago

Hello @jaiminRaiyani Please resolve the conflicts

Marchand-Nicolas commented 2 weeks ago

@jaiminRaiyani Waiting for conflicts to be resolved in order to merge

jaiminRaiyani commented 2 weeks ago

@Marchand-Nicolas please review it i have resolved the conflict