search

lfglabs-dev / starknet.quest

The on-chain quest tool of Starknet
https://starknet.quest
33 stars 121 forks source link

wallet-amount #925

Closed Josh-121 closed 1 week ago

Josh-121 commented 1 week ago

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

Resolves: #NA

Other information

Summary by CodeRabbit

vercel[bot] commented 1 week ago

@Josh-121 is attempting to deploy a commit to the LFG Labs Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai[bot] commented 1 week ago

Walkthrough

The changes involve the addition of a new state variable totalBalance in the profileCard.tsx component to manage and display a user's total balance fetched asynchronously from the argentPortfolioService. A new function calculateTotalBalance is introduced in the argentPortfolioService.ts file to compute the total value of user tokens based on their wallet address. The component's rendering logic is updated to reflect this new balance. Modifications are also made in the questDetails.tsx and questDetails.tsx components to improve error handling for task names, while adjustments in parser.ts streamline tile data processing.

Changes

File Change Summary
components/UI/profileCard/profileCard.tsx - Added state variable totalBalance: number | null.
- Implemented useEffect to fetch total balance using calculateTotalBalance.
- Updated rendering logic to display totalBalance.
services/argentPortfolioService.ts - Introduced asynchronous function calculateTotalBalance(walletAddress: string, currency: "USD" | "EUR" | "GBP" = "USD"): Promise<number>.
- Function fetches user tokens and calculates total balance with error handling.
components/admin/questDetails.tsx - Updated logic for customError prop to use case-insensitive check for task names.
components/quests/questDetails.tsx - Refined logic for customError prop with case-insensitive check for task names.
utils/parser.ts - Removed null coalescing operators in calculations within buildTileData method, affecting tile data processing.

Possibly related PRs

Suggested reviewers

📜 Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
📥 Commits Reviewing files that changed from the base of the PR and between 438d14fddbaee980109fab69f7f836e7a04d0003 and 803a29f9904944acd08fbb5e20f6135d874bfa6a.
⛔ Files ignored due to path filters (1) * `package-lock.json` is excluded by `!**/package-lock.json`
📒 Files selected for processing (3) * `components/UI/profileCard/profileCard.tsx` (5 hunks) * `components/quests/questDetails.tsx` (1 hunks) * `services/argentPortfolioService.ts` (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (2) * components/UI/profileCard/profileCard.tsx * components/quests/questDetails.tsx
🔇 Additional comments (3)
services/argentPortfolioService.ts (3) `28-28`: **LGTM! Improved error message format.** The enhanced error message now includes the response text, which will help with debugging API issues. --- `137-171`: **Well-implemented balance calculation with proper error handling!** Good practices observed: - Proper error handling at both function and loop levels - Correct handling of token decimals - AbortController support for cancellation - Detailed error logging --- `146-164`: _:hammer_and_wrench: Refactor suggestion_ **Consider caching token info outside the loop.** The current implementation fetches token info for each token inside the loop. This could be optimized by fetching all token info once before the loop. ```diff try { const tokens = await fetchUserTokens(walletAddress, { signal }); // Fetch all tokens in wallet + const tokenInfo = await fetchTokens({ signal }); // Fetch once outside loop let totalBalance = 0; for (const token of tokens) { try { - const tokenInfo = await fetchTokens({ signal }); const decimals = tokenInfo[token.tokenAddress]?.decimals ?? 18; const adjustedBalance = Number(token.tokenBalance) / 10 ** decimals; ``` Additionally, consider implementing the parallel processing optimization from the previous review using `Promise.all` to improve performance further.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 2:42pm