search

lfhbento / timeboxed-watchface

A simple, clean and customizable watchface for the Pebble smartwatch
MIT License
52 stars 19 forks source link

Phone battery #26

Open jumper047 opened 4 years ago

jumper047 commented 4 years ago

I added phone battery widget to your watchface, and after testing it seems works good enough to share:).

lfhbento-gt commented 4 years ago

@jumper047 Sorry for the delay on this! I don't have an android device handy at the moment to test it, but I'll see what I can do to get this out :)

jumper047 commented 4 years ago

Seems like it is my turn to apologize for late reply:)

edanaher commented 4 years ago

FYI, I'm now running this on my watch. It took a while for the battery to show up; there seemed to be some weird interaction where it was getting weather messages back instead of battery messages, leaving the phone battery display empty. But it suddenly started working after some debugging.

But it's been working great for most of the day, and I don't think I ended up changing anything meaningful.

(I also noticed there seemed to be a couple places using mixed tabs/spaces, which I suspect is causing the indenting issues under discussion.)

jumper047 commented 4 years ago

@edanaher can you try an watchface with latest commit? I think it will fix an issue with battery. And thank you for pointing me to tabs/spaces, may be it is worth to enable whitespace symbols by default:)

edanaher commented 4 years ago

This morning the phone battery stopped updating for me again (possibly relatedly, my pebble failed to charge overnight and completely ran out of battery; I wonder if starting up fresh broke whatever lucky event got it working in the first place).

However, after installing the newest version, it seems to be working again.

Well, more precisely, I merged master in (to keep my weather updates merged into master since this branch split off) and fixed up the whitespace issues (it seemed like a good idea). Notably, my weather updates used up a key that required incrementing the new ones added here. (Those are the "conflicting files" preventing github from automerging.)

I pushed that branch; I'm not sure if it makes sense to submit a PR to this PR to update it, let jumper047 duplicate the changes, or just submit a fresh PR for that branch and abandon this one; annoyingly, I can't seem to get a "clean" PR for this branch (github keeps showing a bunch of changes that seem unnecessary to me).

jumper047 commented 4 years ago

@edanaher thx for your fixes! I cherry-picked them to this PR.