search

lfhbento / timeboxed-watchface

A simple, clean and customizable watchface for the Pebble smartwatch
MIT License
52 stars 19 forks source link

Update BT vibe #5

Open pjexposito opened 8 years ago

pjexposito commented 8 years ago

I've added a new BT pattern to distinguish between a normal notification and a disconnect notification.

pjexposito commented 8 years ago

Ok, it's perfect for me. Thanks.

El 8 oct. 2016 20:02, "Luis Felipe Hussin Bento" notifications@github.com escribió:

@hussin commented on this pull request.

Hi! Thanks for the PR! See my comment below :)

In src/screen.c https://github.com/hussin/timeboxed-watchface/pull/5#pullrequestreview-3412180 :

@@ -43,7 +43,12 @@ void bt_handler(bool connected) { } else { bool did_vibrate = persist_exists(KEY_BLUETOOTHDISCONNECT) ? persist_read_int(KEY_BLUETOOTHDISCONNECT): 0; if (is_bluetooth_vibrate_enabled() && !is_user_sleeping() && !did_vibrate) {

  • vibes_long_pulse();
  • static uint32_t const segments[] = { 200, 100, 100, 100, 500 };

This is a good idea, but I think this pattern is pretty long and other users might not like it. It's a total of a whole second vibration pattern, so it might be a little too long. Maybe just {200, 100, 100} would be better?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hussin/timeboxed-watchface/pull/5#pullrequestreview-3412180, or mute the thread https://github.com/notifications/unsubscribe-auth/ADgohhJBQvFWRbhUZ8NpHboqVG-W5jTBks5qx9rSgaJpZM4KMTK_ .