search

lfiondella / SRT

Software Reliabilty Testing
5 stars 9 forks source link

Save Plot, scale plot, subset data range #12

Closed a1729nikora closed 8 years ago

a1729nikora commented 9 years ago

These changes implement subsetting by data range, saving data and trend plots, and scaling the data and trend plots by linking the plot height to its width, which is automatically set (ggplot doesn't do auto height correctly).

The data and trend plot has been renamed "DataAndTrendPlot" from "distPlot" in ui.R.

arhik commented 9 years ago

Hello alen ... does this code break the flow in any of the four tabs.

arhik commented 9 years ago

I observed that when different models were selected in the third tab and we navigate back to second tab there will be an error in the plot area.

arhik commented 9 years ago

This is where we need to track the models too....

arhik commented 9 years ago

I fixed it in the last commit. But git says its up-to-date with the base branch. I dont really know why. But i trusted it the same way you do last time and i spent a lot of debugging time to make it functional again...

arhik commented 9 years ago

Let me know if you still struggle to understand what we mean.... If you feel there is a way around other than keeping track of models, we are open to look into it. Keep posting us with your updates.

Thanking you karthik

a1729nikora commented 9 years ago

HI, Karthik,

Thanks for the note – I haven’t gotten to that part on the third tab yet.

Regards, Allen N.

Allen P. Nikora, Ph.D. Program Element Manager, Assurance Technology Program Office Software Element

Jet Propulsion Laboratory California Institute of Technology 4800 Oak Grove Drive Pasadena, CA 91109-8099 Mail Stop 125-233

vox: 818.393.1104 fax: 818.393.1362 email: Allen.P.Nikora@jpl.nasa.gov

From: Karthik Katipally notifications@github.com<mailto:notifications@github.com> Reply-To: lfiondella/SRT reply@reply.github.com<mailto:reply@reply.github.com> Date: Thursday, August 13, 2015 at 7:39 AM To: lfiondella/SRT SRT@noreply.github.com<mailto:SRT@noreply.github.com> Cc: Allen Nikora Allen.P.Nikora@jpl.nasa.gov<mailto:Allen.P.Nikora@jpl.nasa.gov> Subject: Re: [SRT] Save Plot, scale plot, subset data range (#12)

I observed that when different models were selected in the third tab and we navigate back to second tab there will be an error in the plot area.

— Reply to this email directly or view it on GitHubhttps://github.com/lfiondella/SRT/pull/12#issuecomment-130705234.