Fix: Generate project mvn settings files in maven verify workflow

lfit / releng-reusable-workflows

Reusuable workflows developed by LF Release Engineering

Apache License 2.0

1 stars 9 forks source link

Fix: Generate project mvn settings files in maven verify workflow #114

Closed jwagantall closed 7 months ago

jwagantall commented 7 months ago

Use s4u/maven-settings-action to setup maven settings.xml The following variables need to be present in the project:

CONTAINER_PUBLIC_REGISTRY
CONTAINER_PULL_REGISTRY
CONTAINER_PUSH_REGISTRY
CONTAINER_STAGING_REGISTRY
DOCKERHUB_USER
NEXUS_ORG
NEXUS_USER
NEXUS3_USER And the following secrets need to be defined:
NEXUS3_READONLY_PASSWORD
NEXUS3_PASSWORD
DOCKERHUB_PASSWORD
NEXUS_PASSWORD

jwagantall commented 7 months ago

@MightyNerdEric thank you for your input. I think the biggest issue is having the settings constructed using these variables. Is there a way that we can take these servers/user/pass and add them to the project's global-settings file? If so we can pick them from there but not sure how the passwords would be introduced.

Wouldn't it be nice if GH could store secret files? :)

eb-oss commented 7 months ago

GH can store secret files. For example, this is a replacement for creating the global settings file that I came up with:

      - name: Create global settings file
        run: |
          echo "${{ vars.MVN_GLOBAL_SETTINGS }}" > settings.xml

I'm using a variable there, but a secret would work much the same way.

jwagantall commented 7 months ago

Oh,, I see... so MVN_GLOBAL_SETTINGS can contain a full file, with indentation and all ?