search

lfit / releng-reusable-workflows

Reusuable workflows developed by LF Release Engineering
Apache License 2.0
1 stars 9 forks source link

composed-tox-sonar-cloud.yaml is broken #177

Open zxiiro opened 3 months ago

zxiiro commented 3 months ago

It seems the workflow composed-tox-sonar-cloud.yaml is broken and throws the following error:

Error reusable workflows should be referenced at the top-level `jobs.*.uses' key, not within steps

Looks like there is a misconfiguration in the yaml somewhere.

ModeSevenIndustrialSolutions commented 1 month ago

You're right, it's because the tox-verify workflow is being called from a step, whereas re-usable workflows have to be called as self-contained/top-level jobs. I suspect the subsequent step:

- name: Run Sonar Cloud scan
  uses: sonarsource/sonarcloud-github-action@master

...needs to be merged into a single core workflow, where the two steps can be called together? We'll need to check where it is being used though, as changing the behaviour might cause unintended breakage. However, I suspect the tox-verify step might instead be better constructed as an action, which would also solve the problem?