lfit / releng-reusable-workflows

Reusuable workflows developed by LF Release Engineering
Apache License 2.0
1 stars 9 forks source link

Feat: Add node.js build action #184

Closed ModeSevenIndustrialSolutions closed 2 months ago

ModeSevenIndustrialSolutions commented 2 months ago

Required for new ONAP projects, such as portal-ng-ui. Allows the node version and build tool to be specified.

ModeSevenIndustrialSolutions commented 2 months ago

@zxiiro @jwagantall Please could you take a look at this pull request and provide a review? The action has been tested as part of a re-usable workflow I am testing over here: https://github.com/ModeSevenIndustrialSolutions/portal-ng-ui/actions/runs/11016508759/job/30592191353 I'm not ready to add the workflow yet, that might take some more effort.

zxiiro commented 2 months ago

@zxiiro @jwagantall Please could you take a look at this pull request and provide a review? The action has been tested as part of a re-usable workflow I am testing over here: https://github.com/ModeSevenIndustrialSolutions/portal-ng-ui/actions/runs/11016508759/job/30592191353 I'm not ready to add the workflow yet, that might take some more effort.

I reviewed this earlier in a different PR. Why'd you close it an open a new one rather than keeping the previous one open?